On Wed, Oct 18, 2006 at 06:30:59AM -0700, David L Norris wrote:

> Yes, ultimately the problem is that people are still using quotes around
> filenames in their Filefilter directive.  Even if we switched to
> fork-exec users would need to stop single-quoting their filenames in
> that way.

It's hard to fix a fundamentally broken design.  And the patch seems
to not really have helped.

Dave's example:

    '/path/to/'&& rm -Rf /'&&echo .pdf'
    => \'/path/to/\'&& rm -Rf /\'&&echo .pdf\'

Ok, what about this:

    \'/path/to/\'&& rm -Rf /\'&&echo .pdf\'
    => \\'/path/to/\\'&& rm -Rf /\\'&&echo .pdf\\'


The code also has some buffer overrun potential.

Might have to change FileFilter option from:

    FileFilter .doc catdoc "-s8859-1 -d8859-1 '%p'"

to

    FileFilter .doc catdoc -s8859-1 -d8859-1 %p

which makes more sense.

Not sure how to do that on Windows where I'd still use popen.  I don't
have a way to test on Windows.


-- 
Bill Moseley
moseley@hank.org

Unsubscribe from or help with the swish-e list: 
   http://swish-e.org/Discussion/

Help with Swish-e:
   http://swish-e.org/current/docs
   swish-e@sunsite.berkeley.edu