Skip to main content.
home | support | download

Back to List Archive

RE: Swish::Filter dies with MIME::Types

From: Kissman, Paul (BLC) <Paul.Kissman(at)not-real.state.ma.us>
Date: Thu Nov 06 2003 - 13:42:47 GMT
Bill,

Yes your patch enabled the ID3toHTML module to load without the MP3::Tag
error.

I haven't actually tried to index any MP3 files though.

Thanks.

Paul J. Kissman 
Library Information Systems Specialist
Massachusetts Board of Library Commissioners
648 Beacon St.
Boston, MA  02215
paul.kissman@state.ma.us
www.mlin.lib.ma.us or www.mlin.org
617-267-9400 / 800-952-7403 (in-state)
Fax: 617-421-9833



 

-----Original Message-----
From: Bill Moseley [mailto:moseley@hank.org] 
Sent: Wednesday, November 05, 2003 2:51 PM
To: Kissman, Paul (BLC)
Cc: Multiple recipients of list
Subject: Re: [SWISH-E] Swish::Filter dies with MIME::Types

On Wed, Nov 05, 2003 at 11:23:02AM -0800, Kissman, Paul (BLC) wrote:
> >> Loading filter: [SWISH/Filters/ID3toHTML.pm]
> trying to load [MP3::Tag]
>  ** Loaded MP3::Tag **
> -Skipped http://10.21.5.112/mblc/ldev/illform.pdf due to
'filter_content' user supplied function #1 death 'Can't locate object
method "export_to_level" via package "MP3::Tag" at
/usr/local/lib/swish-e/perl/SWISH/Filter.pm line 662.

Oh, I suppose that's a bug.  It's calling Exporter's export_to_level()
method via the module.  That call is there to export symbols into the
correct package (the calling package instead of the current
SWISH::Filter package).

Can you try something?


Index: Filter.pm.in
===================================================================
RCS file: /cvsroot/swishe/swish-e/filters/SWISH/Filter.pm.in,v
retrieving revision 1.4
diff -u -r1.4 Filter.pm.in
--- Filter.pm.in        22 Oct 2003 19:25:17 -0000      1.4
+++ Filter.pm.in        5 Nov 2003 19:46:55 -0000
@@ -659,7 +659,7 @@
         $self->mywarn(" ** Loaded $mod **");

         # Export back to caller
-        $mod->export_to_level( 1 );
+        $mod->export_to_level( 1 ) if $mod->can('export_to_level');
     }
     return 1;
}

-- 
Bill Moseley
moseley@hank.org
Received on Thu Nov 6 13:55:02 2003